Skip to content

fix(add-team-label): fall back to team-bots for bot accounts - #327

Merged
HowardBraham merged 2 commits into
mainfrom
add-team-label-bot-fallback
Nov 13, 2026
Merged

HowardBraham merged 2 commits into
mainfrom
add-team-label-bot-fallback

Conversation

@HowardBraham

@HowardBraham HowardBraham commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

add-team-label fails the job with "Team label not found" for any author missing from topology.json. Release changelog PRs are authored by metamask-ci[bot], which isn't listed, so their Add team label check fails.

When the lookup finds nothing and the PR author's type is Bot, the action now applies team-bots. Humans missing from the topology still fail as before.

Testing

Ran the action from a fork workflow pinned to this branch, with a stubbed topology file because the planning repo is private:

  • A PR opened by github-actions[bot] got team-bots.
  • A PR opened by a human not in the topology failed with "Team label not found".

Related PRs

  • github-tools #326: merge-previous-releases keeps the [Unreleased] changelog link current
  • Extension #47954 and Mobile #39756: stop maintaining per-bot lists in the client repos. Their Add team label check passes for metamask-ci[bot] once this is released and pinned.

@HowardBraham
HowardBraham merged commit ddfa71e into main Nov 13, 2026
9 checks passed
@HowardBraham
HowardBraham deleted the add-team-label-bot-fallback branch November 13, 2026 21:27
@HowardBraham HowardBraham self-assigned this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants