Repository navigation
Conversation
Replaced multiplication with Math.multiplyExact for overflow checks.
dlucas489
requested review from
DenizAltunkapan,
alxkm and
yanglbme
as code owners
November 13, 2026 16:21
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7755 +/- ##
=========================================
Coverage 82.40% 82.40%
- Complexity 8476 8477 +1
=========================================
Files 845 845
Lines 26225 26225
Branches 5122 5122
=========================================
Hits 21610 21610
Misses 3828 3828
Partials 787 787 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Silent overflow in Pow.pow fixed. Prior to this, Pow.pow(2, 63) returned Long.MIN_VALUE, and Pow.pow(2, 64) returned 0.
The updated method uses Math.multiplyExact to throw ArithmeticException when the result is exceeded by the long range.
Related issue: #7751
This PR is for a CS440 assignment and targets my own fork.
The full test suite is passing with mvn test. CONTRIBUTING.md was followed, variables follow Java naming conventions and code is formatted using clang-format.