Skip to content

fix(maths): correct float rounding in num_digits_fast for large integers - #15754

Open
SaifAli-S wants to merge 1 commit into
TheAlgorithms:masterfrom
SaifAli-S:fix-num-digits-fast-rounding
Open

SaifAli-S wants to merge 1 commit into
TheAlgorithms:masterfrom
SaifAli-S:fix-num-digits-fast-rounding

Conversation

@SaifAli-S

Copy link
Copy Markdown

Describe your change

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Fixes #15753

num_digits_fast() in maths/number_of_digits.py previously evaluated math.floor(math.log10(abs(n)) + 1). For integers where abs(n) >= 10**16 - 1 (exceeding IEEE 754 53-bit float mantissa precision), floating-point rounding near powers of ten caused an off-by-one error (e.g. num_digits_fast(10**16 - 1) evaluated to 17 instead of 16).

This fix verifies the logarithmic estimate against integer powers of ten (10 ** (digits - 1) and 10 ** digits), correcting any floating-point rounding discrepancies while maintaining $O(1)$ fast calculation speed. Added regression doctests covering boundary values ($10^{16}-1$, $10^{16}$, $10^{50}-1$, and negative integers).

Checklist

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues, then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: num_digits_fast() returns incorrect digit count for large integers

1 participant