Repository navigation
Match typed-path lint URL detection to runtime roots - #65490
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Open
Jake Bailey (jakebailey) wants to merge 1 commit into
Jake Bailey (jakebailey) wants to merge 1 commit into
Conversation
Drive-like prefixes are URL roots unless they satisfy the runtime's DOS root rules. Treating every second-character colon as a drive bypasses URL query and fragment validation for strings that runtime rejects. Require a letter and a rooted drive suffix, reuse the URL classifier for suffix parsing, and cover rejected queries alongside accepted drive and URL edge cases in the analyzer fixtures.
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch)
and
a balanced review from Copilot
November 13, 2026 22:53
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the typed-path URL and Windows drive-root detection changes.
No open issues 🎉
What changed in this PR
Aligns typed-path lint URL detection with runtime path-root handling, distinguishing Windows drive roots from URL-like paths.
Changes:
- Restricts drive-root detection to alphabetic drive letters followed by a colon and either a separator or the end of the string.
- Reuses URL detection when extracting URL path components.
- Adds accepted and rejected constructor cases and updates expected diagnostics.
| File | Description |
|---|---|
tools/customlint/typedpaths.go |
Corrects drive-root detection and shares URL classification logic. |
tools/customlint/testdata/typedpaths/typedpaths.go.golden |
Updates expected diagnostics for the new regression cases. |
tools/customlint/testdata/typedpaths/typedpaths.go |
Adds coverage for drive roots, URL-like paths, and query or fragment characters. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint rule was wrong here.