Repository navigation
feat: add items accessors to synonym sets and curation sets - #156
Merged
haydenhoang merged 2 commits intoNov 10, 2026
Merged
Conversation
Collaborator
|
lgtm! |
haydenhoang
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SynonymSetItemsandSynonymSetItem(sync and async) to supportsynonym_sets[name].items[id].retrieve(),.upsert()and.delete(), matching the docs snippets that currently raiseAttributeErrorCurationSetItemsandCurationSetItem(sync and async) with the same shape forcuration_sets[name].items[id]items.retrieve(limit=, offset=)for listing anditems.upsert(id, item)as a shortcut for upserting by idSynonymItemUpsertSchemaandCurationItemCreateSchemaout as the body types withoutid, since the item endpoint takes the id from the path and mypy rejected the docs snippetSynonymItemSchemaandCurationItemUpsertSchemaunchanged by making them subclasses that addidlist_items,get_item,upsert_itemanddelete_itemthrough the new accessor and widenupsert_itemto accept bodies with or withoutidtests/synonym_set_items_test.pyandtests/curation_set_test.py